On 01.10.2024 18:51, Andrew Cooper wrote: > On 01/10/2024 4:14 pm, Jan Beulich wrote: >> Use the generic framework from xen/linkage.h. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com> although...
Thanks. >> @@ -132,6 +132,7 @@ ENTRY(s3_resume) >> pop %rbx >> pop %rbp >> ret >> +END(do_suspend_lowlevel) >> >> .data >> .align 16 >> @@ -142,5 +143,4 @@ saved_cr0: .quad 0 >> saved_ssp: .quad 0 >> #endif > > ... we do need something for these 3 variables, or they want to move > into a C file. We have DATA_LOCAL(). Moving to a C file would be odd, as they're not used outside of this file (and hence aren't global). Jan