On 02/10/2024 8:41 am, Jan Beulich wrote:
> Further use the generic framework from xen/linkage.h. While there drop
> excess alignment and move to .bss.
>
> Requested-by: Andrew Cooper <[email protected]>
> Signed-off-by: Jan Beulich <[email protected]>
> ---
> Of course alongside ASM_INT() we could introduce ASM_QUAD() and
> ASM_QUAD_LOCAL() (only the latter needed right here) to aid readability.
> Thoughts?
Honestly, ASM_INT() hiding a .long is confusing enough already.
ASM_C_{INT,LONG}() wouldn't be as bad. At least they're clear about
being a particular type in another language.
> --- a/xen/arch/x86/acpi/wakeup_prot.S
> +++ b/xen/arch/x86/acpi/wakeup_prot.S
> @@ -1,3 +1,5 @@
> +#define DATA_FILL 0 /* For the .bss contributions at the bottom. */
> +
I really feel that here is the wrong place for this to live.
Why isn't it in xen/linkage.h? When is data typically padded with
anything other than 0's?
~Andrew
