On 03/10/2024 2:11 am, Marek Marczykowski-Górecki wrote: > On Wed, Oct 02, 2024 at 04:27:19PM +0100, Frediano Ziglio wrote: >> On Wed, Oct 2, 2024 at 3:04 PM Marek Marczykowski-Górecki >> <[email protected]> wrote: >>> On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote: >>>> This series came from part of the work of removing duplications between >>>> boot code and rewriting part of code from assembly to C. >>>> Rewrites EFI code in pure C. >>> The MB2+EFI tests on Adler Lake fail with this series: >>> https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1478766782 >>> Looking at the VGA output (unfortunately not collected by the test >>> itself) it hangs just after bootloader, before printing anything on the >>> screen (or even clearing it after bootloader). The serial is silent too. >>> >> I tried multiple times to take a look at the logs, but I keep getting error >> 500. > 500? That's weird. Anyway, serial log is empty, so you haven't lost > much. > But also, I've ran it a couple more times and it is some regression. > Staging reliably passes while staging+this series fails. > > Unfortunately I don't have any more info besides it hangs before > printing anything on serial or VGA. Maybe it hanging only on Intel but > not AMD is some hint? Or maybe it's some memory layout or firmware > differences that matter here (bootloader is exactly the same)? > FWIW some links: > successful staging run on ADL: > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146338 > failed staging+this run on ADL: > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980330394 > successful staging run on Zen3+: > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146359 > successful staging+this run on Zen3+: > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146359
Ok, we should do several things. Frediano, can you split out the efi_multiboot2() prototype in asm/efi.h and submit it separately from introducing efi_multiboot2_prelude(). Mechanically, it's a somewhat-large part of the patch, and won't be related to whatever other failure is going on here. Everyone, is it time to consider earlyprintk() ? This is not the first time something like this has happened, and it wont be the last. I for one am quite bored of doing ad-hoc debugging each time... ~Andrew
