On 04/10/2024 7:43 am, Jan Beulich wrote: > On 03.10.2024 19:04, Andrew Cooper wrote: >> The FRED spec architecturalises the Event Type encoding, previously exposed >> only in VMCB/VMCS fields. >> >> Introduce the constants in x86-defns.h, making them a bit more consice, and >> retire enum x86_event_type. >> >> Take the opportunity to introduce X86_ET_OTHER. It's absence appears to be a >> bug in Introspection's Monitor Trap Flag support, when considering VECTORING >> events during another VMExit. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks. > >> --- a/xen/arch/x86/include/asm/x86-defns.h >> +++ b/xen/arch/x86/include/asm/x86-defns.h >> @@ -204,4 +204,13 @@ >> #define X86_MT_UCM 0x07 /* UC- */ >> #define X86_NUM_MT 0x08 >> >> +/* Event Types. */ >> +#define X86_ET_EXT_INTR 0 /* External Interrupt */ >> +#define X86_ET_NMI 2 /* NMI */ >> +#define X86_ET_HW_EXC 3 /* Hardware Exception (#PF/#GP/etc) */ >> +#define X86_ET_SW_INT 4 /* Software Interrupt (INT $n) */ >> +#define X86_ET_PRIV_SW_EXC 5 /* Privileged Software Exception (ICEBP/INT1) >> */ >> +#define X86_ET_SW_EXC 6 /* Software Exception (INT3, INTO) */ >> +#define X86_ET_OTHER 7 /* Misc event: MTF=0, SYSCALL=1, SYSENTER=2 */ > ET could of course mean a lot of things; sadly no sufficiently short but > still less ambiguous alternative comes to mind, so ET is going to be it. Yeah, I considered this quite a lot before settling on X86_ET_*. By coincidence, X86_MT_* are visible in context, so we do have prior art here. ~Andrew
