On 09.10.2024 19:29, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 3:53 PM BST, Jan Beulich wrote: >> On 01.10.2024 14:38, Alejandro Vallejo wrote: >>> Implements the helper for mapping vcpu_id to x2apic_id given a valid >>> topology in a policy. The algo is written with the intention of >>> extending it to leaves 0x1f and extended 0x26 in the future. >>> >>> Toolstack doesn't set leaf 0xb and the HVM default policy has it >>> cleared, so the leaf is not implemented. In that case, the new helper >>> just returns the legacy mapping. >> >> Is the first sentence of this latter paragraph missing an "If" or "When" >> at the beginning? As written I'm afraid I can't really make sense of it. > > It's a statement of current affairs. Could be rewritten as... > > The helper returns the legacy mapping when leaf 0xb is not implemented (as > is the case at the moment). > > Does that look better?
Yes. Jan
