On 11.10.2024 10:45, Roger Pau Monné wrote:
> On Mon, Oct 07, 2024 at 04:16:19PM +0200, Federico Serafini wrote:
>> Refactor the code to avoid an implicit fallthrough and address
>> a violation of MISRA C:2012 Rule 16.3: "An unconditional `break'
>> statement shall terminate every switch-clause".
>>
>> No functional change.
>>
>> Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com>
>> ---
>> Changes in v2:
>> - improved description.
>> ---
>> xen/drivers/passthrough/pci.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 5a446d3dce..a5705def3f 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char
>> *str)
>> {
>> case 1: case 2: case 4:
>> if ( *s )
>> - default:
>> return -EINVAL;
>> + break;
>
> Would you mind adding a newline here between the break and the default
> case?
I actually took the liberty to do so while committing (already a few days
ago).
Jan
