Re: [PATCH] xen/public: increment domctl interface version

[Jürgen Groß]

On 14.10.24 09:14, Jan Beulich wrote:

On 14.10.2024 09:06, Juergen Gross wrote:

The recent addition of the XEN_DOMCTL_dt_overlay function was missing
the related update of XEN_DOMCTL_INTERFACE_VERSION, as it has been the
first interface change of the 4.20 release cycle.

Fixes: 4c733873b5c2 ("xen/arm: Add XEN_DOMCTL_dt_overlay and device attachment to 
domains")

I'm confused: That change (a) pre-dates the branching of 4.20 and (b)
bumped the version ...

--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -21,7 +21,7 @@
  #include "hvm/save.h"
  #include "memory.h"

+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000018

-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000017

... from 0x16 to 0x17. And for no apparent reason, as plain additions don't
require a bump. Didi you maybe mean to reference a different commit?

Oh, indeed. I wanted to reference d6e9a2aab39e.

And regarding to "plain additions don't require a bump": 4c733873b5c2 did
a plain addition and bumped the version.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature