On 08.11.2024 21:11, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/mach-default/mach_mpspec.h > +++ /dev/null > @@ -1,10 +0,0 @@ > -#ifndef __ASM_MACH_MPSPEC_H > -#define __ASM_MACH_MPSPEC_H > - > -#define MAX_IRQ_SOURCES 256 > - > -/* Generic (i.e. installer) kernels need lots of bus entries. */ > -/* Maximum 256 PCI busses, plus 1 ISA bus in each of 4 cabinets. */
This (presumably obsolete, but still) reasoning is entirely lost ... > -#define MAX_MP_BUSSES 260 > - > -#endif /* __ASM_MACH_MPSPEC_H */ > --- a/xen/arch/x86/include/asm/mpspec.h > +++ b/xen/arch/x86/include/asm/mpspec.h > @@ -3,7 +3,9 @@ > > #include <xen/cpumask.h> > #include <asm/mpspec_def.h> > -#include <mach_mpspec.h> > + > +#define MAX_IRQ_SOURCES 256 > +#define MAX_MP_BUSSES 260 ... for why it's 260 here. Imo the value either wants lowering to 256 (for there hardly being anything ISAish in 64-bit systems), or at least that half of the comment retaining. Jan
