On 2024-11-18 09:58, Jan Beulich wrote:
On 16.11.2024 01:23, Stefano Stabellini wrote:
Currently the identifiers characters limit is arbitrarily set to 40.
It
causes a few violations as we have some identifiers longer than 40.
Increase the limit to another rather arbitrary limit of 64. Thanks to
this change, we remove a few violations, getting us one step closer to
marking Rules 5.2 and 5.4 as clean.
Also update the ECLAIR config that was actually set to 63 as character
limit.
What I don't really understand: With the Eclair config already having
said
63, how come we did see patches aiming at dealing with the limit being
just
40? IOW - how would those (supposed) issue even have been spotted.
Hi Jan,
the issue was spotted by Andrew, and therefore we made the patches to
align the configuration with the limits chosen by the project, which
makes those violations appear. It is also possibile to do it the other
way around (align the rst with the ECLAIR configuration), which spares
the need for additional deviations.
In that case, I agree that 63 is better than 64.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
