On 19/11/2024 8:19 am, Jan Beulich wrote:
> On 18.11.2024 18:18, Andrew Cooper wrote:
>> Eclair complains that neither reloc_trampoline{32,64}() can see their
>> declarations.
>>
>> reloc_trampoline32() needs to become asmlinkage, while reloc_trampoline64()
>> needs declaring properly in a way that both efi-boot.h and reloc-trampoline.c
>> can see.
>>
>> Introduce boot-helpers.h for the purpose.
>>
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> Reviewed-by: Jan Beulich <jbeul...@suse.com>

Thanks.

>> --- /dev/null
>> +++ b/xen/arch/x86/include/asm/boot-helpers.h
>> @@ -0,0 +1,13 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Declarations for helper functions compiled for both 32bit and 64bit.
>> + *
>> + * The 32bit forms are called only from assembly, so no declaration is 
>> provide
>> + * here.
>> + */
> How certain are you/we that what is said in the 2nd paragraph will remain
> as a pattern?

Unsure, but there needs to be an explanation of why reloc_trampoline32()
isn't here.

It's not clear how we'd even safely get 32bit declarations here.  They
would really want to be nocall, so the rest of Xen can't use them
accidentally.

The comment is easy enough to change if the circumstances change.

> Also, nit: s/provide/provided/?

Oops yes, will fix.

~Andrew

Reply via email to