> On 3 Dec 2024, at 09:22, Michal Orzel <[email protected]> wrote:
>
> Commit a14593e3995a extended BOOTINFO_{ACPI,SHMEM}_INIT initializers
> list with a new 'type' member but forgot to add trailing commas (they
> were present before). This results in a build failure when building
> with CONFIG_ACPI=y and CONFIG_STATIC_SHM=y:
> ./include/xen/bootfdt.h:155:5: error: request for member 'shmem' in something
> not a structure or union
> 155 | .shmem.common.max_banks = NR_SHMEM_BANKS, \
> | ^
> ./include/xen/bootfdt.h:168:5: note: in expansion of macro
> 'BOOTINFO_SHMEM_INIT'
> 168 | BOOTINFO_SHMEM_INIT \
> | ^~~~~~~~~~~~~~~~~~~
> common/device-tree/bootinfo.c:22:39: note: in expansion of macro
> 'BOOTINFO_INIT'
> 22 | struct bootinfo __initdata bootinfo = BOOTINFO_INIT;
>
> Fixes: a14593e3995a ("xen/device-tree: Allow region overlapping with
> /memreserve/ ranges")
> Signed-off-by: Michal Orzel <[email protected]>
> ---
Thanks Michal, I realise our internal CI is not testing a configuration with
CONFIG_ACPI=y and
CONFIG_STATIC_SHM=y, this is why I missed it.
Reviewed-by: Luca Fancellu <[email protected]
<mailto:[email protected]>>
Cheers,
Luca
