On 02/12/2024 9:49 am, Teddy Astie wrote: > In many places of x86 HVM code, constants integer are used to indicate in > what mode is > running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these > constants are > are written directly as integer which hides the actual meaning of these modes. > > This patch introduces X86_MODE_* macros and replace those occurences with it. > > Signed-off-by Teddy Astie <teddy.as...@vates.tech>
As fed back previously, these are (mostly) not modes. "Mode" has a specific meaning in the x86 architecture which is not this. You are going to have to change your commit message, and choice of constant names. ~Andrew
