On 13/12/2024 12:33, Carlo Nonato wrote:
> 
> 
> Using paste.debian:
> 
> https://paste.debian.net/1339647/

1. Issue I mentioned with prefixing with double underscore
2. Generic helper should not be named ext_regions
3. s/skip_size/min_bank_size/

And still you need to convince others about 128MB limit because I'm not sure.

Imagine, that our kernel+dtb+ramdisk is > 128MB and your first bank is 128MB. 
With your
solution this would fail. Now, imagine that you sort your banks and start with 
the biggest
one. You don't care about its size. It's the biggest one so if it does not fit, 
then that's not
your problem.

~Michal


Reply via email to