On 18.12.2024 19:54, Andrew Cooper wrote:
> Decompressing the kernel is necessary to inspect the ELF notes, but the
> dombuilder will gunzip() secondary modules too.  Specifically gunzip(), no
> other decompression algorithms.
> 
> This may have been necessary in the dim and distant past, but it is broken
> today.  Linux specifically supports concatenating CPIO fragments of differing
> compressions, and any attempt to interpret it with a single algorithm may
> corrupt later parts.
> 
> This was an unexpected discovery while trying to test Xen's gunzip()
> logic (Xen as a PVH guest, with a gzipped XTF kernel as dom0).
> 
> Intepreting secondary modules *should* be left as an exersize to the guest.

Nit: "Interpreting" and "exercise" and ...

> This reduces work done in dom0.
> 
> This is not expected to cause a practical different to guests these days.

... "difference"?

Acked-by: Jan Beulich <jbeul...@suse.com>

Jan

Reply via email to