On Thursday, December 19, 2024 09:32 CET, Jan Beulich <jbeul...@suse.com> wrote:
> On 19.12.2024 00:34, Ariel Otilibili wrote:
> > The if-statement tests `res` is non-zero; meaning the case zero is never
> > reached.
> >
> > Coverity-ID: 1055253
> > Fixes: e2b1ebf4de ("x86: Support booting a bzImage format domain 0 kernel.")
> > Signed-off-by: Ariel Otilibili <ariel.otilibili-ani...@eurecom.fr>
>
> I certainly agree with the change, especially if Coverity complains about it.
> In fact I'd expect Eclair to complain too, for this being unreachable or dead
> code (I'm never sure which one's which in their nomenclature). The Misra
> violation addressed may therefore want mentioning, too.
I didn't know Eclair and Miscra could send warnings. Are they commands
available for that?
>
> However, the commit referenced says "xen/common/inflate.c is taken unmodified
> from Linux v2.6.28." Therefore the preferred approach would be to correct the
> original first, then pull in that patch to our tree. (And yes, the code is
> still as was even in 6.13-rc3.)
So old a commit...
This approach makes sense, Jan; thanks for the feedback. I am sending the patch
to Linux.
And will keep you posted.
>
> Jan
