On 04.01.2025 02:58, Denis Mukhin via B4 Relay wrote:
> From: Denis Mukhin <dmuk...@ford.com>
>
> There are few places which check pv_shim console under CONFIG_PV_SHIM in xen
> console driver. Instead of #ifdef-ing, use new consoled_is_enabled() to
> customize the logic.
>
> Header file now can be included w/o CONFIG_X86.
>
> Signature of consoled_guest_{rx,tx} has changed so the error can be logged.
While you use consoled_guest_tx()'es return value, consoled_guest_rx()'es
remains unused. Why change its return type then in the first place, even
more so when these adjustments are pretty much unrelated to the purpose of
the patch anyway?
> @@ -508,11 +508,9 @@ static void switch_serial_input(void)
> break;
> }
>
> -#ifdef CONFIG_PV_SHIM
> - if ( next_rx == 1 )
> + if ( consoled_is_enabled() && next_rx == 1 )
> domid = get_initial_domain_id();
Isn't this again a bug-fix-like change, without this actually being
mentioned anywhere?
Jan
