On 07.02.2025 01:58, [email protected] wrote: > --- a/xen/include/xen/console.h > +++ b/xen/include/xen/console.h > @@ -8,6 +8,7 @@ > #define __CONSOLE_H__ > > #include <xen/inttypes.h> > +#include <xen/ctype.h> > #include <public/xen.h> > > struct xen_sysctl_readconsole; > @@ -50,4 +51,9 @@ void console_serial_puts(const char *s, size_t nr); > > extern int8_t opt_console_xen; > > +static inline bool is_console_printable(unsigned char c) > +{ > + return isprint(c) || c == '\n' || c == '\t';
Nit: Unlike ctype.h, console.h has no indication of using Linux style. Hence when moving the function here the hard tab should have been switched to four blanks. Can likely be adjusted while committing. Jan
