On 19.02.2025 15:55, Oleksii Kurochko wrote:
> On 2/18/25 6:03 PM, Jan Beulich wrote:
>> On 12.02.2025 17:50, Oleksii Kurochko wrote:
>>> --- a/xen/arch/riscv/Kconfig
>>> +++ b/xen/arch/riscv/Kconfig
>>> @@ -28,16 +28,6 @@ choice
>>> help
>>> This selects the base ISA extensions that Xen will target.
>>>
>>> -config RISCV_ISA_RV64G
>>> - bool "RV64G"
>>> - help
>>> - Use the RV64I base ISA, plus
>>> - "M" for multiply/divide,
>>> - "A" for atomic instructions,
>>> - âFâ/"D" for {single/double}-precision floating-point instructions,
>>> - "Zicsr" for control and status register access,
>>> - "Zifencei" for instruction-fetch fence.
>>> -
>>> endchoice
>> Shouldn't the choice be removed altogether then, for now being empty?
>
> Overlooked that, "Base ISA" choice could be removed too then. or just change
> to:
> choice
> prompt "Base ISA"
> default "ima" if RISCV_64
> help
> This selects the base ISA extensions that Xen will target.
>
> endchoice
Besides me wondering what use that would be (there's no variable to store
the "ima" into), I kind of suspect kconfig might choke on the construct.
Plus even if there was some variable, I'd then ask where it is used. There
isn't a lot of sense in having a Kconfig setting with no user.
Jan
