On 2025-02-27 03:25, Jan Beulich wrote:
On 26.02.2025 21:10, Jason Andryuk wrote:
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -925,7 +928,10 @@ int libxl__arch_hvm_unmap_gsi(libxl__gc *gc, uint32_t
sbdf, uint32_t domid)
int pirq = -1, gsi, r;
gsi = xc_pcidev_get_gsi(CTX->xch, sbdf);
- if (gsi < 0) {
+ if (gsi == -1 && errno == ENOENT) {
+ LOGD(DEBUG, domid, "xc_pcidev_get_gsi no gsi");
+ return 0;
+ } else if (gsi < 0) {
return ERROR_FAIL;
}
Why the special-casing of the value -1?
No good reason. I'll restore it to < 0. I originally thought
xc_pcidev_get_gsi() was returning -errno in gsi. That was not the case.
Regards,
Jason
