On 18/03/2025 9:19 am, Roger Pau Monne wrote:
> The call to ioremap_wc() in video_init() will always fail, because
> video_init() is called ahead of vm_init_type(), and so the underlying
> __vmap() call will fail to allocate the linear address space.
>
> Fix by reverting to the previous behavior and using ioremap() for the VGA
> text buffer.
>
> Fixes: 81d195c6c0e2 ('x86: introduce ioremap_wc()')
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>This is somewhat ugly. ioremap() isn't really any better than ioremap_wc(); this only works because plain ioremap() has a special case for the bottom 1M where it does nothing and exits. What's the consequence of ioremap_wc() failing? Presumably nothing out on the screen when using legacy text mode? >From that point of view, this is an improvement I suppose. ~Andrew
