On 28.03.2025 19:39, Julien Grall wrote: > Hi Jan, > > On 13/03/2025 08:07, Jan Beulich wrote: >> Locally override SYM_PUSH_SECTION() to retain the intended section >> association. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> Tested-by: Luca Fancellu <luca.fance...@arm.com> # arm >> --- >> v7: New. >> >> --- a/xen/arch/arm/arm32/mmu/head.S >> +++ b/xen/arch/arm/arm32/mmu/head.S >> @@ -160,6 +160,13 @@ >> .endm >> >> .section .text.idmap, "ax", %progbits >> +/* >> + * Code below wants to all live in the section established above. >> Annotations >> + * from xen/linkage.h therefore may not switch sections (honoring >> + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. >> + */ >> +#undef SYM_PUSH_SECTION >> +#define SYM_PUSH_SECTION(name, attr) > > AFAICT, SYM_PUSH_SECTION doesn't exist yet. It is introduced by patch > #6. Should this be moved to the last patch?
Perhaps; I failed to notice this when I moved that patch last. I doesn't hurt to live right here, but I agree it's better to move it. > The rest of the patch LGTM to me. So with this addressed: > > Acked-by: Julien Grall <jgr...@amazon.com> Thanks. Jan
