It's not used outside of the CU defining it, and it is clearly of boolean nature.
Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -118,7 +118,7 @@ struct set_mtrr_data { * After all the cpus have came up, then mtrr_aps_sync_end() synchronizes all * the cpus and updates mtrrs on all of them. Then this flag is turned off. */ -int hold_mtrr_updates_on_aps; +static bool hold_mtrr_updates_on_aps; static void cf_check ipi_handler(void *info) /* [SUMMARY] Synchronisation handler. Executed by "other" CPUs. @@ -600,14 +600,14 @@ void mtrr_save_state(void) void mtrr_aps_sync_begin(void) { - hold_mtrr_updates_on_aps = 1; + hold_mtrr_updates_on_aps = true; } void mtrr_aps_sync_end(void) { if (mtrr_if) set_mtrr(~0U, 0, 0, 0); - hold_mtrr_updates_on_aps = 0; + hold_mtrr_updates_on_aps = false; } void asmlinkage mtrr_bp_restore(void) --- a/xen/arch/x86/include/asm/mtrr.h +++ b/xen/arch/x86/include/asm/mtrr.h @@ -63,7 +63,6 @@ extern uint32_t get_pat_flags(struct vcp paddr_t gpaddr, paddr_t spaddr, uint8_t gmtrr_mtype); extern uint8_t pat_type_2_pte_flags(uint8_t pat_type); -extern int hold_mtrr_updates_on_aps; extern void mtrr_aps_sync_begin(void); extern void mtrr_aps_sync_end(void);