On 11.04.2025 12:54, Roger Pau Monne wrote: > mmio_ro_emulated_write() is only used in pv/ro-page-fault.c, move the > function to that file and make it static. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> with ... > --- a/xen/arch/x86/pv/ro-page-fault.c > +++ b/xen/arch/x86/pv/ro-page-fault.c > @@ -298,6 +298,14 @@ static int ptwr_do_page_fault(struct x86_emulate_ctxt > *ctxt, > * fault handling for read-only MMIO pages > */ > > +struct mmio_ro_emulate_ctxt { > + unsigned long cr2; > + /* Used only for mmcfg case */ > + unsigned int seg, bdf; > + /* Used only for non-mmcfg case */ > + mfn_t mfn; ... the unnecessarily deep indentation corrected here. Jan