On 17.04.2025 14:48, Alejandro Vallejo wrote: > --- /dev/null > +++ b/xen/common/domain-builder/Kconfig > @@ -0,0 +1,18 @@ > + > +menu "Domain Builder Features" > +depends on HAS_BOOT_INFO
That is, what's going to further be added here will not ... > +config DOMAIN_BUILDER ...depend on this, but just on HAS_BOOT_INFO? Seems not very likely, but I'll be looking forward to learn what the plans are. Also, if the entire contents here is to depend on HAS_BOOT_INFO, can't the "source" line pulling in this Kconfig be put inside "if HAS_BOOT_INFO"? That would centralize definition and use of that symbol to a single file. > + bool "Domain builder (UNSUPPORTED)" if UNSUPPORTED > + select LIBFDT > + help > + Xen has a built-in mechanisms to automatically construct domains > + (like dom0) during the boot phase. The domain builder is an enhanced > + form of that mechanism to enable constructing predefined domains > + described on a flattened device tree. I'm not a native speaker, but (perhaps because of that) "on" here reads odd. More logical to me would be "by" or "via". Jan
