Re: [PATCH v3 07/11] vpci: Hide extended capability when it fails to initialize

[Jan Beulich]

On 21.04.2025 08:18, Jiqian Chen wrote:
> --- a/xen/include/xen/pci_regs.h
> +++ b/xen/include/xen/pci_regs.h
> @@ -449,6 +449,7 @@
>  #define PCI_EXT_CAP_ID(header)               ((header) & 0x0000ffff)
>  #define PCI_EXT_CAP_VER(header)              (((header) >> 16) & 0xf)
>  #define PCI_EXT_CAP_NEXT(header)     (((header) >> 20) & 0xffc)
> +#define PCI_EXT_CAP_NEXT_MASK                0xFFC00000U

To avoid introducing redundancy, imo this addition calls for

#define PCI_EXT_CAP_NEXT(header)        MASK_EXTR(header, PCI_EXT_CAP_NEXT_MASK)

now.

Jan