On 23.04.2025 00:49, dm...@proton.me wrote: > On Tue, Apr 08, 2025 at 05:23:17PM +0200, Jan Beulich wrote: >> On 01.04.2025 02:52, dm...@proton.me wrote: >>> From: Denis Mukhin <dmuk...@ford.com> >>> >>> Introduce XEN_X86_EMU_BASELINE and XEN_X86_EMU_OPTIONAL to simplify >>> d->arch.emulation_flags management in the code. >> >> If the simplification is limited to ... >> >>> --- a/tools/python/xen/lowlevel/xc/xc.c >>> +++ b/tools/python/xen/lowlevel/xc/xc.c >>> @@ -159,9 +159,7 @@ static PyObject *pyxc_domain_create(XcObject *self, >>> >>> #if defined (__i386) || defined(__x86_64__) >>> if ( config.flags & XEN_DOMCTL_CDF_hvm ) >>> - config.arch.emulation_flags = XEN_X86_EMU_ALL & >>> - ~(XEN_X86_EMU_VPCI | >>> - XEN_X86_EMU_USE_PIRQ); >>> + config.arch.emulation_flags = XEN_X86_EMU_BASELINE; >>> #elif defined (__arm__) || defined(__aarch64__) >>> config.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; >>> #else >> >> ... just this, I'm not convinced that's worth introducing yet two more items >> into the namespace. > > Sorry, it took me a while to get back to the series. > > The X86_EMU_BASELINE mask is used in two places: in the toolstack (xc.c) and > in domain.c, emulation_flags_ok(), so adding a new flag may require updates > in two places.
Which may be even desirable in this case, so effects can be properly considered at both sites. I wouldn't take it for given that the two will forever need to stay in full sync. Jan
