On Sat Apr 26, 2025 at 12:43 AM BST, Ariadne Conill wrote:
> Previously Xen placed the hypercall page at the highest possible MFN,
> but this caused problems on systems where there is more than 36 bits
> of physical address space.
>
> In general, it also seems unreliable to assume that the highest possible
> MFN is not already reserved for some other purpose.
Thanks for sending this!
Just one more thing on top of what Jan mentioned.
>
> Changes from v1:
> - Continue to use fixmap infrastructure
> - Use panic in Hyper-V setup() function instead of returning -ENOMEM
> on hypercall page allocation failure
>
> Fixes: 620fc734f854 ("x86/hyperv: setup hypercall page")
> Cc: Alejandro Vallejo <agarc...@amd.com>
> Cc: Alexander M. Merritt <alexan...@edera.dev>
> Signed-off-by: Ariadne Conill <ariadne@ariadne.space>
> ---
> xen/arch/x86/guest/hyperv/hyperv.c | 17 +++++++----------
> xen/arch/x86/include/asm/guest/hyperv.h | 3 ---
> 2 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/xen/arch/x86/guest/hyperv/hyperv.c
> b/xen/arch/x86/guest/hyperv/hyperv.c
> index 6989af38f1..0305374a06 100644
> --- a/xen/arch/x86/guest/hyperv/hyperv.c
> +++ b/xen/arch/x86/guest/hyperv/hyperv.c
> @@ -98,7 +98,13 @@ static void __init setup_hypercall_page(void)
> rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> if ( !hypercall_msr.enable )
> {
> - mfn = HV_HCALL_MFN;
> + void *hcall_page = alloc_xenheap_page();
> + if ( !hcall_page )
> + panic("Hyper-V: Failed to allocate hypercall trampoline page");
> +
> + printk("Hyper-V: Allocated hypercall page @ %p.\n", hcall_page);
We should be printing the mfn (or maddr) rather than the virtual address
out of the allocator, IMO. Especially since we need to remap it anyway.
With that:
Reviewed-by: Alejandro Vallejo <agarc...@amd.com>
Cheers,
Alejandro
