[Public] Hi,
> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: Thursday, April 17, 2025 11:12 PM > To: Penny, Zheng <penny.zh...@amd.com> > Cc: Huang, Ray <ray.hu...@amd.com>; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v4 01/15] xen/cpufreq: move "init" flag into common > structure > > On 14.04.2025 09:40, Penny Zheng wrote: > > AMD cpufreq cores will be intialized in two modes, legacy P-state > > mode, and CPPC mode. So "init" flag shall be extracted from specific > > "struct xen_processor_perf", and placed in the common "struct > > processor_pminfo". > > The code change is certainly acceptable, as being largely mechanical. > However, the above doesn't explain _why_ we need that change. There's > probably a little more connection that needs making between that's there and > what > you mean to add. > How about complement the following description: ``` Otherwise, later when introducing new sub-hypercall to propagate CPPC data in commit "xen/x86: introduce new sub-hypercall to propagate CPPC data", we need to pass irrelevant px-specific "struct xen_processor_perf" in set_cppc_pminfo() to just set init flag. ``` > Jan
