Hi Michal,

> On 5 May 2025, at 13:08, Orzel, Michal <michal.or...@amd.com> wrote:
> 
> 
> 
> On 29/04/2025 17:20, Luca Fancellu wrote:
>> Introduce few utility function to manipulate and handle the
> s/few/a few/
> s/function/functions/

Ok

>> 
>> diff --git a/xen/arch/arm/include/asm/mpu.h b/xen/arch/arm/include/asm/mpu.h
>> index 40a86140b6cc..0e0a7f05ade9 100644
>> --- a/xen/arch/arm/include/asm/mpu.h
>> +++ b/xen/arch/arm/include/asm/mpu.h
>> @@ -24,6 +24,70 @@
>> #define NUM_MPU_REGIONS_MASK    (NUM_MPU_REGIONS - 1)
>> #define MAX_MPU_REGION_NR       255
>> 
>> +#ifndef __ASSEMBLY__
>> +
>> +#ifdef CONFIG_ARM_64
>> +/*
>> + * Set base address of MPU protection region.
>> + *
>> + * @pr: pointer to the protection region structure.
>> + * @base: base address as base of the protection region.
>> + */
>> +static inline void pr_set_base(pr_t *pr, paddr_t base)
>> +{
>> +    pr->prbar.reg.base = (base >> MPU_REGION_SHIFT);
> Shouldn't you take MPU_REGION_RES0 into account?

Yes indeed, I’ll fix

Cheers,
Luca

Reply via email to