On 02/05/2025 8:01 am, Jan Beulich wrote: > On 01.05.2025 14:23, Gerald Elder-Vass wrote: >> --- a/xen/arch/x86/Makefile >> +++ b/xen/arch/x86/Makefile >> @@ -58,6 +58,7 @@ obj-y += percpu.o >> obj-y += physdev.o >> obj-$(CONFIG_COMPAT) += x86_64/physdev.o >> obj-y += psr.o >> +obj-y += sbat.o >> obj-y += setup.o >> obj-y += shutdown.o >> obj-y += smp.o > This being x86-specific here without there really being anything x86-specific > about it - what about Arm? > > It being EFI-specific, why put it here rather than in x86/efi/ (and/or, as > per above, in common/efi/, at least for the source file)?
Having just spent a morning debugging, I've told Gerald to keep it in x86. common/efi is an intractable mess and needs turning into a regular part of the build before this suggestion can be actioned. ~Andrew
