On 06/05/2025 12:12 am, Stefano Stabellini wrote:
> On Fri, 2 May 2025, victorm.l...@amd.com wrote:
>> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c
>> b/xen/arch/x86/x86_emulate/x86_emulate.c
>> index 8e14ebb35b..d678855238 100644
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -527,8 +527,8 @@ static inline void put_loop_count(
>> if ( !amd_like(ctxt) && mode_64bit() && ad_bytes == 4 ) \
>> { \
>> _regs.r(cx) = 0; \
>> - if ( extend_si ) _regs.r(si) = _regs.esi; \
>> - if ( extend_di ) _regs.r(di) = _regs.edi; \
>> + if ( extend_si ) _regs.r(si) = (uint32_t)_regs.r(si); \
>> + if ( extend_di ) _regs.r(di) = (uint32_t)_regs.r(di); \
> NIT: code style, alignment of the \
>
> Can be fixed on commit.
>
> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
