On 12/05/2025 1:38 pm, Jan Beulich wrote: >> + * Copyright (C) 1994, 1996, 1998, 2000 Free Software Foundation, Inc. >> + * >> + * This file is part of GnuPG. >> + * >> + * GnuPG is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * GnuPG is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA >> + * >> + * Note: This code is heavily based on the GNU MP Library. >> + * Actually it's the same code with only minor changes in the >> + * way the data is stored; this is to support the abstraction >> + * of an optional secure memory allocation which may be used >> + * to avoid revealing of sensitive data due to paging etc. >> + * The GNU MP Library itself is published under the LGPL; >> + * however I decided to publish this code under the plain GPL. >> + * >> + * mpi.c code extracted from linux @ eef0df6a5953, lib/mpi > I fear this line would go unnoticed with future changes, and hence go stale > rather easily. Menioning the origin in just the commit message ought to be > sufficient. > > Btw - how heavily did you need to adjust the code to pass our Eclair scan? > Depending on that I then might raise the question of converting to proper > Xen style (it currently isn't even proper Linux style, afaict).
I've put this through Eclair. Single R16.3 (missing break) violation. Happy otherwise. ~Andrew
