On 14.05.2025 16:45, Roger Pau Monné wrote: > On Wed, May 14, 2025 at 02:52:39PM +0200, Jan Beulich wrote: >> On 14.05.2025 13:44, Roger Pau Monné wrote: >>> On Wed, May 03, 2023 at 11:46:41AM +0200, Jan Beulich wrote: >>>> This is to make the difference to FLUSH_CACHE_WRITEBACK more explicit. >>>> >>>> Requested-by: Andrew Cooper <andrew.coop...@citrix.com> >>>> Signed-off-by: Jan Beulich <jbeul...@suse.com> >>> >>> Acked-by: Roger Pau Monné <roger....@citrix.com> >> >> Thanks. >> >>> This is however missing the previous calls from SVM/VMX that at this >>> point in the series have already been switched to write-back instead >>> of evict. >> >> Hence why it's this late in the series, i.e. ... >> >>> Maybe this patch should be the 1st of 2nd, so that changes >>> from evict to write-back are done afterwards? >> >> ... I wanted to avoid touching those places twice. (IOW re-ordering would >> be possible, with the extra changes you mention, but I'd prefer not to.) > > Given the concerns with patch 2 I think some re-ordering will be > needed?
Well, if patches 2 and 3 need dropping, this one would naturally move forwards of course. The more that 1 was already committed, and 4 is soon going to be (as being independent of 2 and 3). Jan