On 09.05.2025 11:05, Jiqian Chen wrote: > When init_msi() fails, the previous new changes will hide MSI > capability, it can't rely on vpci_deassign_device() to remove > all MSI related resources anymore, those resources must be > removed in cleanup function of MSI.
That's because vpci_deassign_device() simply isn't called anymore? Could do with wording along these lines then. But (also applicable to the previous patch) - doesn't this need to come earlier? And is it sufficient to simply remove the register intercepts? Don't you need to put in place ones dropping all writes and making all reads return either 0 or ~0 (covering in particular Dom0, while for DomU-s this may already be the case by default behavior)? Jan
