On Mon, May 19, 2025 at 2:52 PM Andrew Cooper <andrew.coop...@citrix.com> wrote: > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Anthony PERARD <anthony.per...@vates.tech> > CC: Michal Orzel <michal.or...@amd.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Julien Grall <jul...@xen.org> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/include/xen/compile.h.in | 3 +++ > xen/tools/process-banner.sed | 5 +++++ > 2 files changed, 8 insertions(+) > > diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in > index 3151d1e7d1bf..9206341ba692 100644 > --- a/xen/include/xen/compile.h.in > +++ b/xen/include/xen/compile.h.in > @@ -1,3 +1,6 @@ > +#ifndef XEN_COMPILE_H > +#define XEN_COMPILE_H > +
Why not follow CODING_STYLE ? OT: Maybe while on it, why not add SPDX comments too ? > #define XEN_COMPILE_DATE "@@date@@" > #define XEN_COMPILE_TIME "@@time@@" > #define XEN_COMPILE_BY "@@whoami@@" > diff --git a/xen/tools/process-banner.sed b/xen/tools/process-banner.sed > index 56c76558bcd9..4cf3f9a1163a 100755 > --- a/xen/tools/process-banner.sed > +++ b/xen/tools/process-banner.sed > @@ -12,3 +12,8 @@ s_(.*)_"\1\\n"_ > > # Trailing \ on all but the final line. > $!s_$_ \\_ > + > +# Append closing header guard > +$a\ > +\ > +#endif /* XEN_COMPILE_H */ > > base-commit: 6fc02ebdd053856221f37ba5306232ac1575332d > prerequisite-patch-id: 7bc1c498ba2c9c4a4939a56a0006f820f47f2a66 > -- > 2.39.5 > > Frediano