On 20.05.25 18:02, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 20/05/2025 14:47, Oleksandr Tyshchenko wrote:
>> An attempt to write access the register (i.e. GICR_PROPBASER,
>> GICR_PENDBASER)
>> which should be ignored (i.e. no virtual ITS present) causes the data
>> about
>
> I assume, this is a guest data abort, rather than Xen crash?
yes
>
>> due to incorrect check at the write_ignore_64 label. The check should be
>> inverted.
>
> OOI, why would a guest try to write to GICR_PROPBASER if the ITS is not
> present? Was it a bug in the OS?
no, it was just me experimenting with redistributor registers.
>
>>
>> Fixes: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for
>> 64-bit registers")
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>
>
> With the commit message clarified and Andrew's comments addressed:
>
> Acked-by: Julien Grall <jgr...@amazon.com>
thanks
>
> Cheers,
>
