On 20.05.2025 23:39, dm...@proton.me wrote: > On Tue, May 20, 2025 at 05:21:06PM +0200, Jan Beulich wrote: >> On 16.05.2025 04:29, dm...@proton.me wrote: >>> From: Denis Mukhin <dmuk...@ford.com> >>> >>> Define per-architecture emulation_flags for configuring domain emulation >>> features. >>> >>> Print d->arch.emulation_flags from 'q' keyhandler for better traceability >>> while debugging. >>> >>> Signed-off-by: Denis Mukhin <dmuk...@ford.com> >>> --- >>> Changes since v1: >>> - dropped comments >>> --- >>> xen/arch/arm/include/asm/domain.h | 1 + >>> xen/arch/ppc/include/asm/domain.h | 1 + >>> xen/arch/riscv/include/asm/domain.h | 1 + >>> xen/common/keyhandler.c | 1 + >>> 4 files changed, 4 insertions(+) >> >> If every arch gains identical fields, accessed from common code, why would >> those need to live in struct arch_domain? > > I did it this way to keep the diff smaller, but I agree such property > makes sense to put in common domain struct. Will update in v3.
Provided there's arch maintainer buy-off on generalizing this. There's (at least) a 3rd option, after all: Have arch-specific and (separate) common emulation flags. Jan
