On 21.05.2025 18:03, Oleksii Kurochko wrote: > Implement init_IRQ() to initalize various IRQs. > > Currently, this function initializes the irq_desc[] array, > which stores IRQ descriptors containing various information > about each IRQ, such as the type of hardware handling, whether > the IRQ is disabled, etc. > The initialization is basic at this point and includes setting > IRQ_TYPE_INVALID as the IRQ type, assigning the IRQ number ( which > is just a consequent index of irq_desc[] array ) to > desc->irq. > > Additionally, the function init_irq_data() is introduced to > initialize the IRQ descriptors for all IRQs in the system. > > Reuse defines of IRQ_TYPE_* from asm-generic/irq-dt.h. > > Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
Acked-by: Jan Beulich <jbeul...@suse.com> > --- > - Add an explanatory comment about NR_IRQS definitions. > - Init desc->irq and desc->action before call of init_one_irq_desc(). > - Drop "desc->action = NULL" as irq_desc[] is zero-initialized. Just to mention: This is odd to read, as it partially invalidates the earlier bullet point. > - Update the commit message: drop mention of NULLing of desc->action. Again only for the future: Adjusting the description to match changes being made is the expected thing (and hence doesn't need mentioning separately, in the common case at least). Jan
