On Fri, May 30, 2025 at 10:01:23AM +0100, Julien Grall wrote: > > > On 29/05/2025 17:23, Edgar E. Iglesias wrote: > > On Thu, May 29, 2025 at 04:59:21PM +0100, Julien Grall wrote: > > > Hi Edgar, > > > > Hi Julien, > > > > > > > > > > On 29/05/2025 16:50, Edgar E. Iglesias wrote: > > > > From: "Edgar E. Iglesias" <edgar.igles...@amd.com> > > > > > > > > Add a per-domain way to optionally disable traps for accesses > > > > to unmapped addresses. > > > > > > > > The domain flag is general but it's only implemented for ARM for now. > > > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.igles...@amd.com> > > > > --- > > > > tools/libs/light/libxl_arm.c | 3 +++ > > > > xen/arch/arm/dom0less-build.c | 3 +++ > > > > xen/arch/arm/domain.c | 3 ++- > > > > xen/arch/arm/domain_build.c | 3 ++- > > > > xen/arch/arm/io.c | 36 > > > > +++++++++++++++++++++++++++++++++-- > > > > xen/common/domain.c | 3 ++- > > > > xen/include/public/domctl.h | 4 +++- > > > > > > Looking at the changelog, I saw you removed the go bindings (although, > > > they > > > were in patch 3). But I don't quite understand why. > > > > I got a little confused. The file tools/golang/xenlight/helpers.gen.go > > has the following at the top: > > // Code generated by gengotypes.py. DO NOT EDIT. > > // source: libxl_types.idl > > > > > > So I got the impression that we shouldn't be editing it. > > Should I edit it manually? Or should I try to rerun gengotypes.py > > to generate these bindings? > > As the file is checked in, I think we expect the developper to rerun > gengotypes.py. Anthony, can you confirm? >
Thanks, I've included a regeneration of the bindings in v3. If it for some reason is not needed we can drop it. Cheers, Edgar
