On 22.05.2025 17:00, Andrew Cooper wrote: > --- a/xen/arch/x86/alternative.c > +++ b/xen/arch/x86/alternative.c > @@ -86,6 +86,11 @@ static bool init_or_livepatch_read_mostly > toolchain_nops_are_ideal; > # define toolchain_nops_are_ideal false > #endif > > +static const unsigned char *get_ideal_nops(unsigned int noplen)
Right here this wants to be init_or_livepatch. I didn't go check whether subsequent patches add a truly non-init caller. If so - fine as is; otherwise with the attribute added: Acked-by: Jan Beulich <[email protected]> Jan
