On 2025-06-04 11:27, Roger Pau Monné wrote:
On Wed, Jun 04, 2025 at 11:22:00AM +0200, Jan Beulich wrote:
It being non-static and it not having a declaration (anymore) violates
one or more Misra rules, iirc.

Fixes: ff3e5dfa7c2d ("x86/mm: move mmio_ro_emulated_write() to PV only file")
Signed-off-by: Jan Beulich <jbeul...@suse.com>

Acked-by: Roger Pau Monné <roger....@citrix.com>

We are not checking for those rules in Eclair I think?  Otherwise this
won't have passed the CI testing.  Or maybe we are just checking
builds with !CONFIG_PV?

Thanks, Roger.

That seems to be the case on x86. On Arm64 there is no override for CONFIG_PV [1], but perhaps that is unset by default? I'm not opposed to having more variants under analysis, but that is not something I can decide on individually.

Thanks,
 Nicola

[1] https://gitlab.com/xen-project/hardware/xen/-/blob/staging/automation/gitlab-ci/analyze.yaml?ref_type=heads

--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253

Reply via email to