On 05.06.2025 17:17, Teddy Astie wrote: > Le 05/06/2025 à 16:51, Jan Beulich a écrit : >> On 30.05.2025 10:48, Teddy Astie wrote: >>> + /* >>> + * If single context invalidation is not supported, we escalate to >>> + * use all context invalidation. >>> + */ >>> + if ( likely(cpu_has_vmx_vpid_invvpid_single_context) ) >>> + goto execute_invvpid; >>> + >>> + type = INVVPID_ALL_CONTEXT; >>> + >>> +execute_invvpid: >> >> There no reason at all to use "goto" here (and with that replaced there's >> then also no style issue with the label placement). > > Should a similar treatment be made for vpid_sync_vcpu_gva ?
I wouldn't require anyone to do a re-work, but the latest when it is touched the next time it likely should be polished some. For context, while iirc we didn't accept that rule, Misra in principle also demands that "goto" not be used. Jan
