On 09/06/2025 22:54, Stewart Hildebrand wrote:
> In file included from ./include/xen/pci.h:72,
> from drivers/pci/pci.c:8:
> ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared inside
> parameter list will not be visible outside of this definition or declaration
> [-Werror]
> 131 | static inline int pci_sanitize_bar_memory(struct rangeset *r)
> | ^~~~~~~~
> cc1: all warnings being treated as errors
>
> Fixes: 4acab25a9300 ("x86/vpci: fix handling of BAR overlaps with non-hole
> regions")
> Signed-off-by: Stewart Hildebrand <stewart.hildebr...@amd.com>
> ---
> xen/arch/arm/include/asm/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h
> index 1605ec660d0b..1bbb9d780193 100644
> --- a/xen/arch/arm/include/asm/pci.h
> +++ b/xen/arch/arm/include/asm/pci.h
> @@ -17,6 +17,8 @@
>
> #ifdef CONFIG_HAS_PCI
>
> +#include <xen/rangeset.h>
Just for the struct, I think it would be better to forward declare it (at least
this is what we recently started to prefer). Especially given that rangeset.h
also forward declares it.
That said, I don't find it mandatory, so with or without:
Reviewed-by: Michal Orzel <michal.or...@amd.com>
~Michal
