On 13.06.2025 12:12, Frediano Ziglio wrote:
> Just code style change.
>
> Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
> ---
> xen/include/xen/pci.h | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
Aiui Eclair will object to declarations now (again?) going out of sync with
definitions.
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -89,8 +89,8 @@ struct pci_dev_info {
> bool is_extfn;
> bool is_virtfn;
> struct {
> - u8 bus;
> - u8 devfn;
> + uint8_t bus;
> + uint8_t devfn;
> } physfn;
> };
>
> @@ -209,26 +209,26 @@ static always_inline bool pcidevs_trylock(void)
> #define ASSERT_PDEV_LIST_IS_READ_LOCKED(d) ((void)(d))
> #endif
>
> -bool pci_known_segment(u16 seg);
> -bool pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func);
> +bool pci_known_segment(uint16_t seg);
> +bool pci_device_detect(uint16_t seg, uint8_t bus, uint8_t dev, uint8_t func);
> int scan_pci_devices(void);
> -enum pdev_type pdev_type(u16 seg, u8 bus, u8 devfn);
> -int find_upstream_bridge(u16 seg, u8 *bus, u8 *devfn, u8 *secbus);
> +enum pdev_type pdev_type(uint16_t seg, uint8_t bus, uint8_t devfn);
> +int find_upstream_bridge(uint16_t seg, uint8_t *bus, uint8_t *devfn, uint8_t
> *secbus);
As you make style adjustments, please also obey to other aspects of style, like
line length here.
Overall, while I don't mind the change, I'm not sure all of it is worthwhile.
We're still only halfway through converting functions taking (s,b,d,f) tuples
to take either struct pci_dev * or sbdf_t instead. Going straight to there
where possible might be a more desirable approach.
Jan
