On 24.07.2025 11:48, Roger Pau Monne wrote:
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -121,11 +121,14 @@ static void cf_check ns16550_delayed_resume(void *data);
>
> static u8 ns_read_reg(const struct ns16550 *uart, unsigned int reg)
> {
> - void __iomem *addr = uart->remapped_io_base + (reg << uart->reg_shift);
> + void __iomem *addr;
While making the change, would you mind adding const volatile here and ...
> @@ -139,11 +142,14 @@ static u8 ns_read_reg(const struct ns16550 *uart,
> unsigned int reg)
>
> static void ns_write_reg(const struct ns16550 *uart, unsigned int reg, u8 c)
> {
> - void __iomem *addr = uart->remapped_io_base + (reg << uart->reg_shift);
> + void __iomem *addr;
... just volatile here? Preferably with that:
Reviewed-by: Jan Beulich <jbeul...@suse.com>
Jan
