On 24/07/2025 12:40 pm, Aidan Allen wrote:
> Added the ability to view the paging pool size via the debug keys
>
> Signed-off-by: Aidan Allen <aidan.all...@cloud.com>

You should have CC'd all the x86 maintainers.  Adding Jan and Roger.

> ---
>  xen/arch/x86/domain.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 503a55705b..b64d09a9c8 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -253,6 +253,10 @@ void dump_pageframe_info(struct domain *d)
>                 page->count_info, page->u.inuse.type_info);
>      }
>
> +    printk("    Domain paging pool: total: %d, free: %d, p2m: %d\n",
> +           d->arch.paging.total_pages, d->arch.paging.free_pages,
> +           d->arch.paging.p2m_pages);

The %d's should be %u's, as each of these are unsigned quantities.  This
can be fixed on commit.

Otherwise, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>

> +
>      nrspin_unlock(&d->page_alloc_lock);
>  }
>
> --
> 2.47.1


Reply via email to