On 28/07/2025 6:03 am, Jiqian Chen wrote: > vpci_remove_register() only supports removing a register in a time, > but the follow-on changes need to remove all registers within a range. > So, refactor it to support removing all registers in a given region. > > And it is no issue to remove a non exist register, so remove the > __must_check prefix. > > Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Bisection says this causes an assertion failure in the unit test. Running /usr/lib/xen/tests/test_vpci Assertion failed: vpci_remove_registers(test_pdev.vpci, 16, 2) (main.c: main: 407) FAILED: /usr/lib/xen/tests/test_vpci Full logs, not that they're of any more help: https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/1956817587 ~Andrew