On 25.07.2025 17:06, Edwin Török wrote:
> Using `aa2u` tool.
>
> Signed-off-by: Edwin Török <edwin.to...@cloud.com>
How come the use of that tool made ...
> --- a/xen/include/public/arch-x86/pmu.h
> +++ b/xen/include/public/arch-x86/pmu.h
> @@ -75,8 +75,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_pmu_regs_t);
> #define PMU_SAMPLE_PV (1<<3) /* Sample from a PV guest */
>
> /*
> - * Architecture-specific information describing the state of the guest at
> - * the time of a PMU interrupt.
> + * Architecture-specific information describing state of the guest at
> + * the time of PMU interrupt.
> + * Even if the interrupt arrived while inside Xen, this will always contain
> + * the guest's state.
> */
> struct xen_pmu_arch_guest {
... this comment change, or yet more interesting, ...
> --- a/xen/include/public/pmu.h
> +++ b/xen/include/public/pmu.h
> @@ -148,7 +148,7 @@ struct xen_pmu_hv_stacktrace {
> * arrives while in Xen.
> * */
> struct xen_pmu_arch_guest guest;
> -#define XEN_PMU_STACKTRACE_PAD 48
> +#define XEN_PMU_STACKTRACE_PAD 56
> uint8_t pad2[XEN_PMU_STACKTRACE_PAD];
> };
... this value in the public interface?
Jan
