On 05.08.2025 10:27, Chen, Jiqian wrote: > On 2025/8/5 16:10, Jan Beulich wrote: >> On 05.08.2025 05:49, Jiqian Chen wrote: >>> When MSI-X initialization fails vPCI will hide the capability, but >>> remove of handlers and data won't be performed until the device is >>> deassigned. Introduce a MSI-X cleanup hook that will be called when >>> initialization fails to cleanup MSI-X related hooks and free it's >>> associated data. >>> >>> As all supported capabilities have been switched to use the cleanup >>> hooks call those from vpci_deassign_device() instead of open-code the >>> capability specific cleanup in there. >>> >>> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> >>> --- >>> cc: "Roger Pau Monné" <roger....@citrix.com> >>> --- >>> v9->v10 changes: >>> * Call all cleanup hook in vpci_deassign_device() instead of cleanup_msix(). >> >> Isn't this rather an omission in an earlier change, and hence may want to >> come separately and with a Fixes: tag? > This is not really an omission, after all, all the cleanup hooks were > implemented at the end of this series. > And judging from the commit message(which was written by Roger in v8), Roger > also agreed to add them in this patch.
I disagree. Of the two xfree()-s you remove here from vpci_deassign_device(), one should have been removed by patch 3 already. Which would require the part of the patch here to be put in place earlier on. Jan
