On 03.08.2025 11:47, Penny Zheng wrote: > --- a/xen/include/hypercall-defs.c > +++ b/xen/include/hypercall-defs.c > @@ -198,7 +198,9 @@ dm_op(domid_t domid, unsigned int nr_bufs, > xen_dm_op_buf_t *bufs) > sysctl(xen_sysctl_t *u_sysctl) > #endif > domctl(xen_domctl_t *u_domctl) > +#if PG_log_dirty > paging_domctl_cont(xen_domctl_t *u_domctl) > +#endif > #ifndef CONFIG_PV_SHIM_EXCLUSIVE > platform_op(xen_platform_op_t *u_xenpf_op) > #endif > @@ -294,6 +296,8 @@ dm_op compat do > compat do do > hypfs_op do do do do do > #endif > mca do do - - - > +#if PG_log_dirty > paging_domctl_cont do do do do - > +#endif
While putting together my pair of patches, I figured that using PG_log_dirty here is wrong. asm/paging.h isn't (and cannot easily be) included, and hence the compiler will consider PG_log_dirty uniformly 0, no matter what .config holds. Jan
